Skip to content

Commit

Permalink
fix: #2165 tooltip and aura var conditions in cata
Browse files Browse the repository at this point in the history
  • Loading branch information
ascott18 committed Jul 6, 2024
1 parent f64136f commit 879f8fe
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
7 changes: 4 additions & 3 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Bug report
description: Report a problem with TellMeWhen
labels: defect
labels:
- defect
body:
- type: dropdown
id: wowversion
Expand All @@ -10,8 +11,8 @@ body:
multiple: true
options:
- Retail
- Wrath Classic
- Classic/Classic SoM
- Cata Classic
- Classic or SoD
validations:
required: true
- type: input
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## v10.2.7
* Initial support for WoW 11.0
* Fix GetTalentTabInfo call for SOD Phase 4
* Fix Tooltip Number conditions for Cata

## v10.2.6
* Additional updates for Cataclysm Classic, including handling for new player resource types.
Expand Down
6 changes: 2 additions & 4 deletions Components/Core/Conditions/Categories/BuffsDebuffs.lua
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,6 @@ ConditionCategory:RegisterCondition(4, "BUFFTOOLTIP", {
end,
icon = "Interface\\Icons\\inv_elemental_primal_mana",
tcoords = CNDT.COMMON.standardtcoords,
hidden = not TMW.isRetail,
funcstr = function(c)
if CanUsePackedAuras(c) then
return [[AuraVariableNumberPacked(c.Unit, c.Spells.First, "isHelpful", ]] .. (tostring(c.Checked)) .. [[) c.Operator c.Level]]
Expand Down Expand Up @@ -548,7 +547,7 @@ for i = 1, 3 do -- BUFFTOOLTIPSCAN
icon = not TMW.isRetail and "Interface\\Icons\\spell_ice_lament" or "Interface\\Icons\\ability_priest_clarityofwill",
tcoords = CNDT.COMMON.standardtcoords,
funcstr = function(c)
if CanUsePackedAuras(c) then
if C_TooltipInfo and CanUsePackedAuras(c) then
return [[AuraTooltipNumberPacked(c.Unit, c.Spells.First, "isHelpful", ]] .. (tostring(c.Checked)) .. [[, ]] .. i .. [[) c.Operator c.Level]]
end
return [[AuraTooltipNumber(c.Unit, c.Spells.First, "HELPFUL]] .. (c.Checked and " PLAYER" or "") .. [[", ]] .. i .. [[) c.Operator c.Level]]
Expand Down Expand Up @@ -786,7 +785,6 @@ ConditionCategory:RegisterCondition(14, "DEBUFFTOOLTIP", {
end,
icon = "Interface\\Icons\\spell_shadow_lifedrain",
tcoords = CNDT.COMMON.standardtcoords,
hidden = not TMW.isRetail,
funcstr = function(c)
if CanUsePackedAuras(c) then
return [[AuraVariableNumberPacked(c.Unit, c.Spells.First, "isHarmful", ]] .. (tostring(c.Checked)) .. [[) c.Operator c.Level]]
Expand Down Expand Up @@ -815,7 +813,7 @@ for i = 1, 3 do -- DEBUFFTOOLTIPSCAN
icon = "Interface\\Icons\\spell_fire_flameshock",
tcoords = CNDT.COMMON.standardtcoords,
funcstr = function(c)
if CanUsePackedAuras(c) then
if C_TooltipInfo and CanUsePackedAuras(c) then
return [[AuraTooltipNumberPacked(c.Unit, c.Spells.First, "isHarmful", ]] .. (tostring(c.Checked)) .. [[, ]] .. i .. [[) c.Operator c.Level]]
end
return [[AuraTooltipNumber(c.Unit, c.Spells.First, "HARMFUL]] .. (c.Checked and " PLAYER" or "") .. [[", ]] .. i .. [[) c.Operator c.Level]]
Expand Down
1 change: 1 addition & 0 deletions Options/CHANGELOG.lua
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ TMW.CHANGELOG = [==[
## v10.2.7
* Initial support for WoW 11.0
* Fix GetTalentTabInfo call for SOD Phase 4
* Fix Tooltip Number conditions for Cata
## v10.2.6
* Additional updates for Cataclysm Classic, including handling for new player resource types.
Expand Down

0 comments on commit 879f8fe

Please sign in to comment.