-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nushell): Use def --env
instead of def-env
#1681
fix(nushell): Use def --env
instead of def-env
#1681
Conversation
@jthegedus @Stratus3D this is an urgent bugfix. When the latest version of nushell is released in a few weeks, asdf will break without this patch. Aside: Will it be possible to review my other PRs as well? |
@jthegedus @Stratus3D ping. Nushell 0.88 has been released with |
This is a minimal change that has no impact to any part of asdf core mechanics and only updates asdf autocomplete interface for nushell. As of the last few updates, the script shipped with asdf simply throws a syntax error in nushell, as |
@hyperupcall GitHub is not letting me modify this PR because of the source fork permissions so I cannot resolve the conflict (Fish version update), can you update this when you have the time? Thanks |
Thanks |
Summary
Nushell recently deprecated use of
def-env
. Migration is clear. This issue implements the deprecation and this issue implementsdef --env
. It states:So, the minimum version needs to be bumped to 0.86. Unfortunately, this means older versions will no longer be support, but it is difficult as nushell has many backwards incompatible changes being made
Current version of nushell is 0.87.0, which was released last week. To ensure this fix gets merged before the release of 0.88.0, it should be merged before ~December 13
Closes #1680
Closes #1700