Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support for Windows with Git-Bash or MSYS2 Bash #1801

Closed
wants to merge 1 commit into from

Conversation

daramkun
Copy link

Summary

Support Windows through Git-Bash or MSYS2 Bash (Not WSL2) for Use vscode-elixir-ls on Windows

Other Information

  • On *NIX
    • It works as it used to.
  • On Windows
    • When executing the asdf reshim command, create a *.bat file, and when executing the file, execute the command through bash.
    • asdf reshim remove .exe extension. (ex: erl.exe -> erl)

- .exe executables are shims to non-extensions path
- .bat files to reshim for cmd or Powershell
- .bat execute bash script with bash built Windows
@daramkun daramkun requested a review from a team as a code owner November 25, 2024 15:25
@Stratus3D
Copy link
Member

Hi @daramkun I'm sorry for the late reply here. Thanks for taking the time to create this PR. However, I've been re-writing asdf in Golang (PR #1805) and recently merged the Go code. It no longer makes sense to merge these changes for the Bash code since the next release will only contain the Go code. If support for Windows with Bash is still lacking in the Go code another PR targeting the Go code is welcome (latest dev builds here - https://github.com/asdf-vm/asdf/releases/tag/54d15e3).

@Stratus3D Stratus3D closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants