Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix floating window disappears when another app gains focus #113

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix floating window disappears when another app gains focus #113

wants to merge 2 commits into from

Conversation

Gasparoken
Copy link
Member

This is the solution for issue aseprite/aseprite#4265

@Gasparoken Gasparoken assigned Gasparoken and dacap and unassigned Gasparoken Nov 21, 2024
@Gasparoken Gasparoken mentioned this pull request Nov 21, 2024
Open
@Gasparoken Gasparoken requested a review from dacap November 22, 2024 14:36
@aseprite-bot
Copy link
Collaborator

clang-tidy review says "All clean, LGTM! 👍"

@dacap
Copy link
Member

dacap commented Dec 4, 2024

I've just rebased the commit and fix conflicts in https://github.com/dacap/laf/tree/fix-float-window (changed minor things): a1498f0

Anyway testing the floating_windows example (the same happens on aseprite) I noticed a little flickering and sometimes the floating windows goes back to the main window:

Screen.Recording.2024-12-04.at.8.51.04.AM.mov

@dacap dacap assigned Gasparoken and unassigned dacap Dec 4, 2024
@Gasparoken
[osx] Fix sometimes the floating window flickers during app activation
97a64e7 
This solution sends floating window to the background of
the main window on app deactivation to avoid the flickering.
@aseprite-bot
Copy link
Collaborator

Hi there!

One or more of the commit messages in this PR do not match our code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@aseprite-bot
Copy link
Collaborator

clang-tidy review says "All clean, LGTM! 👍"

@Gasparoken Gasparoken assigned dacap and unassigned Gasparoken Dec 5, 2024
@dacap
Copy link
Member

dacap commented Dec 9, 2024

The floating window is going to the back always:

Screen.Recording.2024-12-09.at.12.45.52.PM.mov

@dacap dacap assigned Gasparoken and unassigned dacap Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacap dacap Awaiting requested review from dacap

Assignees

@Gasparoken Gasparoken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gasparoken @aseprite-bot @dacap