Create a new laf-dlgs-proc executable to run the file dialog in a child process #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aseprite-bot
reviewed
Feb 4, 2025
|
|
||
| class Delegate : public dlgs::FileDialogDelegate { | ||
| public: | ||
| void onFolderChange(const std::string& path) override |
There was a problem hiding this comment.
warning: method 'onFolderChange' can be made static [readability-convert-member-functions-to-static]
Suggested change
| void onFolderChange(const std::string& path) override | |
| static void onFolderChange(const std::string& path) override |
| } | ||
|
|
||
| // Initialize COM library. | ||
| base::CoInit com; |
There was a problem hiding this comment.
warning: variable 'com' of type 'base::CoInit' can be declared 'const' [misc-const-correctness]
Suggested change
| base::CoInit com; | |
| base::CoInit const com; |
| WerSetFlags(WER_FAULT_REPORTING_NO_UI); | ||
|
|
||
| Delegate delegate; | ||
| dlgs::FileDialog::Spec spec; |
There was a problem hiding this comment.
warning: variable 'spec' of type 'dlgs::FileDialog::Spec' can be declared 'const' [misc-const-correctness]
Suggested change
| dlgs::FileDialog::Spec spec; | |
| dlgs::FileDialog::Spec const spec; |
| if (result == dlgs::FileDialog::Result::Error) | ||
| return 1; | ||
| else if (result == dlgs::FileDialog::Result::Cancel) | ||
| return 0; |
There was a problem hiding this comment.
warning: do not use 'else' after 'return' [readability-else-after-return]
Suggested change
| return 0; | |
| if (result == dlgs::FileDialog::Result::Cancel) | |
| return 0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to fix aseprite/aseprite#4412 in some way, this is not yet ready because it looks like a child process cannot use
IModalWindow::Showwith a parent process HWND handle.