Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing check in relation inversion logic #57

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

ronenh
Copy link
Contributor

@ronenh ronenh commented Sep 23, 2024

It was adding terms that refer to non-existent realtions.

The following manifest causes an error when calling GetGraph to search for objects that a given subject has access to.

user:
  relations:
    manager: user

resource:
  relations:
    viewer: user#manager

It was adding terms that refer to non-existent realtions.
@ronenh ronenh force-pushed the bugfix/search-objects branch from 94067f5 to 5052209 Compare September 23, 2024 17:55
@ronenh ronenh requested a review from gertd September 23, 2024 17:55
@coveralls
Copy link

coveralls commented Sep 23, 2024

Pull Request Test Coverage Report for Build 10999738514

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 60.781%

Files with Coverage Reduction New Missed Lines %
graph/objects.go 2 88.81%
Totals Coverage Status
Change from base Build 10829675514: -0.04%
Covered Lines: 2816
Relevant Lines: 4633

💛 - Coveralls

@gertd gertd merged commit 5736b57 into main Sep 23, 2024
2 checks passed
@gertd gertd deleted the bugfix/search-objects branch September 23, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants