Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ds.RelationIdentifier doesn't match empty subject relations #124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ds.RelationIdentifier doesn't match empty subject relations #124

wants to merge 2 commits into from

Conversation

ronenh
Copy link
Contributor

@ronenh ronenh commented Feb 6, 2025 •
edited
Loading

If a RelationIdentifier has an empty subject relation its filter should include relations that do have a subject relation.

Depends on:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13187820623

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 28.547%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/ds/relation.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/ds/relation.go 1 46.77%
Totals Coverage Status
Change from base Build 13019909177: -0.02%
Covered Lines: 990
Relevant Lines: 3468
💛 - Coveralls

@ronenh ronenh mentioned this pull request Feb 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronenh @coveralls