-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add Challenge & Competition #32
Draft
ryumiyax
wants to merge
15
commits into
asesidaa:dev
Choose a base branch
from
ryumiyax:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ryumiyax
commented
Oct 24, 2024
•
edited
Loading
edited
- Game response
- Add data tables (challengeCompete, participant, song, bestScore)
- Add query to collect user's challenge & competition data
- Map data to 3906 & 3209
- Add serials of list page
- Multi User support Thanks to @AkaiiKitsune
- Add challengeCompeteCard
- Show songs in card
- Fix: Cards have different height
- Add Challenge list page
- Card title of challenge shows direction flow of challenge
- Add accept / reject as action button for the challenged donder
- Add finished / waiting / accepted / rejected as status indicator
- Add waiting / accepted / rejected as status indicator
- Add finished as status indicator
- Show Win/Failed after finished
- Create challenge by dialog (select up to 1 music)
- Add Competition list page
- Add participate as action button for donders
- Add finished / fulfilled as status indicator
- Add fulfilled as status indicator
- Add finished as status indicator
- Shou rank after finished
- Create competition by dialog (select up to 3 music)
- Add Official Competition list page
- Add participate as action button for donders
- Add finished / fulfilled as status indicator
- Add fulfilled as status indicator
- Add finished as status indicator
- Show Rank after finished
- Create official competition by dialog (only user 0 can do this, select up to 5 music) (ps: I haven't played official competition)
- Fix: Add button have strange height
- Add detail page
- Top view contains title, id and comment
- Song list
- Participants rank list
- QRCode, scan to add folder contains songs of challenge / competition / official competition
- Add Create limit (maximum processing challenge / competition )
- Add public setting (private Competition share by link or with password)
- Add no bother mode, enable by default, can't be select by others from challenge tareget list
…ption can be null
ryumiyax
changed the title
Add Challenge & Competition
Feature: Add Challenge & Competition
Oct 24, 2024
Moved the page code to .cs files for all Challenge pages Made the challenge section only visibile when user is connected
We no longer match admins to baid 0 but rather use their actual isAdmin value from the db
Admins should be able to register to competitions and to accept / reject challenges. By default however, creating a competition as an admin does not make you register to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.