-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR-5790 Add CORS preflight OPTIONS request #803
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reweeden
force-pushed
the
rew/pr-5790-preflight-cors
branch
2 times, most recently
from
March 19, 2024 21:03
f47ea3b
to
e961c0f
Compare
reweeden
force-pushed
the
rew/pr-5790-preflight-cors
branch
from
March 21, 2024 17:01
e961c0f
to
f1162ab
Compare
reweeden
force-pushed
the
rew/pr-5790-preflight-cors
branch
from
March 21, 2024 20:28
f1162ab
to
e924b5e
Compare
mattp0
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! That was pretty quick and not too many changes.
Should we be concerned about the decrease in code cov here? Seems like there could be some easy unit tests added.
mckadesorensen
approved these changes
Mar 21, 2024
reweeden
force-pushed
the
rew/pr-5790-preflight-cors
branch
from
March 22, 2024 15:53
e924b5e
to
5b35486
Compare
Yea I just added a some unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some libraries will automatically make this
OPTIONS
request and we need to respond with the appropriate headers to prevent cross origin requests from being blocked.