Merge pull request #295 from ash-jc-allen/fix/uc-browser-bug

Fix bug where the OS name cannot be determined from the user agent
ash-jc-allen · Aug 27, 2024 · 195662f · 195662f
2 parents 6bcc485 + bb8c1a3
commit 195662f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/Classes/UserAgent/ParserPhpDriver.php b/src/Classes/UserAgent/ParserPhpDriver.php
@@ -24,7 +24,8 @@ public function getOperatingSystem(): ?string
             return null;
         }
 
-        return $this->parser->os->name ?: null;
+        /** @phpstan-ignore-next-line  */
+        return $this->parser->os->name ?? null;
     }
 
     public function getOperatingSystemVersion(): ?string

diff --git a/tests/Unit/Classes/ResolverTest.php b/tests/Unit/Classes/ResolverTest.php
@@ -84,6 +84,19 @@ public static function trackingFieldsProvider(): array
                     'device_type' => 'robot',
                 ],
             ],
+
+            // UC Browser 7
+            [
+                'Mozilla/4.0 (compatible; MSIE 6.0; ) Opera/UCWEB7.0.2.37/28/999',
+                [
+                    'operating_system' => null,
+                    'operating_system_version' => null,
+                    'browser' => 'UC Browser',
+                    'browser_version' => '7.0',
+                    'referer_url' => null,
+                    'device_type' => 'mobile',
+                ],
+            ],
         ];
     }