chore: Fix warnings related to params of AshPhoenix.Form.submit (#226)

ash-project · Nov 4, 2024 · d045c6b · d045c6b
1 parent 75f8e5a
commit d045c6b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/lib/ash_admin/components/resource/data_table.ex b/lib/ash_admin/components/resource/data_table.ex
@@ -203,7 +203,10 @@ defmodule AshAdmin.Components.Resource.DataTable do
                 []
               end
 
-            case AshPhoenix.Form.submit(socket.assigns.query, action_opts: action_opts) do
+            case AshPhoenix.Form.submit(socket.assigns.query,
+                   action_opts: action_opts,
+                   params: nil
+                 ) do
               {:ok, data} -> assign(socket, :data, {:ok, data})
               {:error, query} -> assign(socket, data: {:error, all_errors(query)}, query: query)
             end

diff --git a/lib/ash_admin/components/resource/form.ex b/lib/ash_admin/components/resource/form.ex
@@ -1657,7 +1657,7 @@ defmodule AshAdmin.Components.Resource.Form do
      |> assign(:form, form)}
   end
 
-  def handle_event("save", _, socket) do
+  def handle_event("save", %{"form" => form_params}, socket) do
     form = socket.assigns.form
 
     before_submit = fn changeset ->
@@ -1666,7 +1666,11 @@ defmodule AshAdmin.Components.Resource.Form do
       |> Map.put(:actor, socket.assigns[:actor])
     end
 
-    case AshPhoenix.Form.submit(form, before_submit: before_submit, force?: true) do
+    case AshPhoenix.Form.submit(form,
+           before_submit: before_submit,
+           force?: true,
+           params: form_params
+         ) do
       {:ok, result} ->
         redirect_to(socket, result)
 

diff --git a/lib/ash_admin/components/resource/generic_action.ex b/lib/ash_admin/components/resource/generic_action.ex
@@ -309,7 +309,7 @@ defmodule AshAdmin.Components.Resource.GenericAction do
     #             []
     #           end
 
-    #         case AshPhoenix.Form.submit(socket.assigns.query, action_opts: action_opts) do
+    #         case AshPhoenix.Form.submit(socket.assigns.query, action_opts: action_opts, params: nil) do
     #           {:ok, data} -> assign(socket, :data, {:ok, data})
     #           {:error, query} -> assign(socket, data: {:error, all_errors(query)}, query: query)
     #         end