feat: Sort resource_group_labels by given order #225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's say, we have this in a domain:
Currently,
resource_group_labels
shows labels in ascending alphabetical order and this will result to this in the domain dropdown:This PR let
resource_group_labels
to strictly sort labels as given and this will be the result in the domain dropdown:The reason is that when I tried
ash_admin
withash_paper_trail
, I tried to group all resources withVersion
in a group calledAudit log
which starts with anA
. There is another group calledDomain
. As result,Audit log
group is always at the top and I wanted to actually put this group under theDomain
group.Follow up to #15
Contributor checklist