feat(DataTable): Update DataTable
component to use Cinder for table generation
#357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
DataTable
component to use Cinder for table generation. It grabs the query from the generated form (for actions that take arguments) and passes it to the table, so that Cinder can do its thing.This lets us expose groovy functionality like sorting, filtering, etc.
Discussion points
I've added some initial features for end users - adding
table_sortable_columns
andtable_filterable_columns
in the resource DSL - but we should discuss if/what we should make available.Having things like auto-generated filters does look kind of funny for actions like
by_id
orby_name
, that provide their own filters via arguments. Currently our DSL isn't granular enough to provide different configuration for different read actions - should we expand it?Running
mix assets.deploy
to update the CSS (to include styles from Cinder) seems to have minified the CSS/JS when it wasn't minified before - so it looks like I deleted four bajillion lines of code when I didn't. Is it supposed to be minified? Or not minified?Contributor checklist
Leave anything that you believe does not apply unchecked.