Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trigger a job that uses a generic action #99

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

tunchamroeun
Copy link
Contributor

Contributor checklist

  • Bug fixes include regression tests
  • Features include unit/acceptance tests

Fix issue #89

Any ideas or suggestions?

@zachdaniel
Copy link
Contributor

This is great :) People have been asking for this. One thing I'd like to add, however, is that in this formulation that the primary key of the thing being triggered be made available as an argument to the action input. Then you could trigger arbitrary logic per record.

@tunchamroeun
Copy link
Contributor Author

Thanks for your suggestion.

@tunchamroeun
Copy link
Contributor Author

Hi @zachdaniel , I’ve updated the action input to include primary_key as follows:

%Ash.ActionInput{
  params: %{
    :action_args => "test",
    "primary_key" => %{"id" => "fd1b3728-23fa-4812-986b-a8e4adb738bd"}
  }
}

@zachdaniel zachdaniel merged commit 702089e into ash-project:main Nov 29, 2024
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants