fix: Honour upstream attribute constraints. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the attribute being versioned has a constraint applied, we must also copy that constraint when creating versions.
rgraff
added a commit
to rgraff/ash_paper_trail
that referenced
this pull request
Dec 12, 2023
* main: fix: Honour upstream attribute constraints. (ash-project#31) chore: update deps, add .tool-versions chore: resolve more CI issues chore: update all of our deps chore: update credo/check & fix credo issues ci: add CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the attribute being versioned has a constraint applied, we must also copy that constraint when creating versions.
Contributor checklist