improvement: allow opts to be passed to the generated relationship #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
relationship_optsto thepaper_traildsl. It allows options to be specified that are passed to the generatedhas_many:paper_trail_versionsrelationship that is created on the resource. Any options given override the default options in the existing transformer.This change was made to allow
public?: trueto be specified, allowing the versions relationship to be exposed over graphql, and adding more flexibility.I've covered the change with some unit tests, although there was one existing, unrelated failing test that remains in a failing state.
I have also added a few dsl options to the .formatter locals_without_parens that were missing.