fix: errors messages on embedded forms multiply #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgraff
commented
Oct 10, 2023
| @@ -3509,8 +3509,7 @@ defmodule AshPhoenix.Form do | |||
| |> Enum.map(fn error -> | |||
| %{error | path: trail ++ error.path} | |||
| end) | |||
|
|
|||
| further_errors = further_errors ++ Enum.reject(errors, &(&1.path == trail)) | |||
There was a problem hiding this comment.
further_errors and are concatenated below on line 3542
rgraff
changed the title
zachdaniel
approved these changes
Oct 10, 2023
|
This makes sense to me, looks like the duplication was just a mechanical bug then, happy to merge this. Won't merge it now since its marked as a draft though. |
|
I think it's possible--but I'm not sure how--for form errors that don't match any paths to be filtered out completely. Maybe give #mainliners a heads up on this one. |
|
I'll drop a note in there, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Enum.uniq()on error messages does address my initial bug, but I believe this fixes it at the source. WhenAsh.phoenix_form.synthesize_action_errors/3is called recursively, the embedded form errors are added twice. This fixes the issue for me without the need forEnum.uniq()in the helper. My robust test suite passes and I did some manual testing in my app, but I don't know if this "fix" is appropriate for everyone.Contributor checklist