Nested form errors for argument attribute

[rgraff]

This may be an X/Y problem, but what I'm trying to do is have an action with an argument that is an embedded resource. The argument resource itself may be valid, but in the context of the parent it is invalid, so the parent creates an add an error with the path to the arguments attribute. That error is not being propagated to the nested form of the argument.

This is a test to reproduce the problem.

Discussed here:
https://elixirforum.com/t/setting-path-on-an-error/59857/3

Contributor checklist

• Bug fixes include regression tests
• Features include unit/acceptance tests

[zachdaniel]

Thanks for the PR! Going to merge and poke around a bit.

[zachdaniel]

Alright, so I've addressed some issues with the underlying logic, but the main thing you'll want to do here is not rely on the underlying structure for extracting errors. Use AshPhoenix.Form.errors(form) to get what you need. You can pass a path: AshPhoenix.Form.errors(form, for_path: [:nested_form]) for example, or AshPhoenix.Form.errors(form, for_path: [:all]) to get a map of all paths to errors.

[rgraff]

@zachdaniel I'll try it out. I'm just using the phoenix core components and inputs_for, so I'm not sure how it accesses the errors on the nested form.

[zachdaniel]

Oh, interesting...yeah lets see if my changes helped.

[rgraff]

I can get the errors from AshPhoenix.Form.errors(form, for_path: [:nested_form]) but those errors don't appear on the nested form that comes out of PhoenixComponent.inputs_for/1

Important to note is that errors added by constraints on an embedded resource used as an argument do work.