fix: don't deadlock when lots of async reactors are sharing a concurrency pool. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimsynz
force-pushed
the
fix/shared-concurrency-deadlock
branch
4 times, most recently
from
628ea16 to
16d75db
Compare
|
Some notes from a discussion: state.current_tasks needs to not be used anywhere to limit, we should instead atomically "claim X or fewer available concurrency limit" and then start those tasks. And state.current_tasks is just for us to track what is currently running, not playing a part in the concurrency limit calculation. |
jimsynz
force-pushed
the
fix/shared-concurrency-deadlock
branch
from
16d75db to
2d48eee
Compare
zachdaniel
approved these changes
Sep 27, 2023
jimsynz
force-pushed
the
fix/shared-concurrency-deadlock
branch
from
2d48eee to
c4c49ba
Compare
jimsynz
force-pushed
the
fix/shared-concurrency-deadlock
branch
from
c4c49ba to
d894b79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.