Upgrade AWS library to version 2 #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is now out of date. The addition of lambdas means that we should spend some time trying to make those work. The interface changed slightly, but it might have some broader ramifications. I'm still going through the docs on this one, but my recommendation is to not merge at the moment. |
TylerNoblett
force-pushed
the
js/upgrade-aws-v2-dep
branch
from
1178fda to
c31e651
Compare
jrozner
force-pushed
the
js/upgrade-aws-v2-dep
branch
from
c31e651 to
ba753a0
Compare
|
Rebased on main and resolved conflicts. It looks like all the service worker code and lambdas were written against the new library rather than the old one. We can deploy this into staging and test it out before merging and do a pass over it to see if anything else needs to change. |
TylerNoblett
previously approved these changes
Dec 12, 2023
jkennedyvz
dismissed stale reviews from TylerNoblett and themself
via
51ca083
jkennedyvz
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the golang aws library to the v2 golang library, over the v1 library. It may be worthwhile to hold off on merging this PR until after the metadata PRs are merged, as the lambda introduction would also need to be updated.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.