lint fix

ashnamehrotra · Aug 21, 2023 · 9c8d764 · 9c8d764
1 parent b4c044b
commit 9c8d764
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/controllers/imagejob/imagejob_controller.go b/controllers/imagejob/imagejob_controller.go
@@ -456,24 +456,24 @@ func (r *Reconciler) SetupWithManager(mgr ctrl.Manager) error {
 func podsComplete(podList []corev1.Pod) bool {
 	for i := range podList {
 		if podList[i].Status.Phase == corev1.PodRunning || podList[i].Status.Phase == corev1.PodPending {
-			if containersNotFailed(podList[i]) {
-				return false
-			} else {
+			if containersFailed(&podList[i]) {
 				return true
 			}
+			return false
 		}
 	}
 	return true
 }
 
-func containersNotFailed(pod corev1.Pod) bool {
+func containersFailed(pod *corev1.Pod) bool {
 	statuses := pod.Status.ContainerStatuses
+	log.Info("Statuses", "container statuses", statuses)
 	for i := range statuses {
 		if statuses[i].State.Terminated != nil {
-			return false
+			return true
 		}
 	}
-	return true
+	return false
 }
 
 func (r *Reconciler) updateJobStatus(ctx context.Context, imageJob *eraserv1.ImageJob) error {