Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional components #249

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

aash1999
Copy link
Contributor

Changes made :
Made Star Me On Github button optional
Made View Resume Button optional

@aash1999
Copy link
Contributor Author

@saiteja13427 please look into this PR

@saiteja13427
Copy link
Collaborator

saiteja13427 commented Sep 22, 2022

Thanks for the PR @aash1999

I was thinking it would be great if we have a object dedicated to enabling/disabling buttons and pages.

What do you think @ashutosh1919, shall we do that? Shall we have one customise object wherein users can enable/disable pages, some optional components, some buttons etc?

@ashutosh1919
Copy link
Owner

@saiteja13427 yes I agree. We should do something like that. Otherwise we need to write redundant if conditions.

@saiteja13427
Copy link
Collaborator

Alright

@aash1999 would you like to take this up? We can open an issue, discuss it there and then go for it.

If you are willing to take this up then I will create an issue. Let me know.

@aash1999
Copy link
Contributor Author

@saiteja13427 sounds cool to me. I am in 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants