gRPC Integration #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding source plugin + upgrading maven scala compiler plugin + specifying java compiler compiler and setting jvm version as 1.8
- Fixing a bug in SuuchiPutService - Small refactoring of the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #4
@brewkode Please do have a look at this when you've time. I've implemented Get and Put service methods on the server end (client is a WIP). We need to integrate
HandleOrForwardwrapper on top of these methods to transparently forward based on the partition info.TODOs
getandputoperations)InMemoryStoreimplementation for theStoreabstraction (tracked as part of Implement in-memory store #5Notes
Storeabstraction but the fact that it uses twitter'sFutureput me off. May be if we need to hatch onto the existing community, the whole part is pluggable but our implementations are notAsync- that's something we might want to think about early in the design.