fixed inconsistent output issue

[sumanbyte]

Description

In addressing a problem, I discovered that:

new BikramSambat()
BikramSambat.fromAD(new Date())
were producing inconsistent results.

The issue arose because, when creating a new instance of BikramSambat, the current date was converted to an ISO string and then sliced to reset the UTC hours to 00:00:00. However, when using the static method directly (BikramSambat.fromAD(new Date())), the UTC handling led to slight discrepancies, causing the date calculation to be offset by one day.

Issue Reference

Inconsistent output #48

Proposed Changes

To ensure consistent results between both approaches, I've applied uniform UTC handling for date calculations, maintaining the same logic for resetting the date to 00:00:00 in UTC.

Screenshots / GIFs / Videos

Checklist

• Lint rules are passed correctly
• Code builds correctly
• Created or updated tests for the new code
• All existing and new tests passed
• Pull request title is concise and descriptive.
• Pull request is linked to the related issue.

[ashiishme]

@sumanbyte Thank you so much for taking care of this issue. It's been a long time since I was involved in this project, I totally forgot why we slice the TimeString in the constructor.

I think rather than resetting the TimeString in this PR, I guess it's fine to just remove the slicing from the constructor.

You can do that in this PR and try to run the test and see if all the existing test passes. If yes, you can then add a new test to check if both dates are equal as stated by the original problem.

Let me know what do you think?

[sumanbyte]

As suggested. i removed the slicing operation from the constructor. instead of using the setUTCHours for consistent output incase of partial days. i changed the getDaysBetweenTwoAdDates function to ignore partial days by using math.floor function instead of math.ceil to correctly count the number of days. i wrote test cases for partial days by checking if it outputs 0 incase of the same current date but in the end date adding 5 minutes to it. Another test case i added was to check if both instance date string and static method date string both matches or not.