Bogon.py updates #45
Open
Bogon.py updates #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using sets instead of lists is a faster lookup. Also, compiling the set with networks at module load time will be faster than casting to an ip_network at every iteration. Finally, wrap the function in a try/except to handle potential errors in creating an ip_network instance.
fjahr
reviewed
Jan 5, 2025
| return True | ||
|
|
||
| return False | ||
| try: |
There was a problem hiding this comment.
Hm, this silences the error. I don't think that's what we want here. Generally such an error shouldn't happen here of course but if it does something has been going really wrong and then this function shouldn't pretend that the network is actually fine and not even a bogon. We would probably run into issue later and have a harder time debugging the later that happens.
| return True | ||
| if 65552 <= asn <= 131071: | ||
| # IANA reserved ASNs, no RFC | ||
| special_asns = { |
| return True | ||
|
|
||
| special_ranges = { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the
bogon.pymodule with some performance and clarity improvements, and adds tests for the module.