RPKI parse tests #49
Draft
RPKI parse tests #49
+229
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the previously added check for leading zeros picks up private networks, so it's not exactly what we want here. Instead, separate the format_pfx and is_valid_pfx intents and add tests accordingly. format_pfx checks whether the existing prefix can be coerced to a string and returns it. is_valid_pfx simply checks whether it's a valid pfx or not.
set up a test context to use with pytest's tmp_path pass in the epoch argument exlicitly to prevent conflicts, and adjust context argument parsing to handle that. Add a rpki_raw.json fixture, and a tests/util.py module.
fjahr
reviewed
Jan 19, 2025
| @@ -39,6 +37,12 @@ def __init__(self, args): | |||
| self.epoch = self.args.epoch | |||
| self.epoch_dir = "r" + self.args.epoch | |||
| self.epoch_datetime = repro_epoch | |||
| # This is only for testing, to set an epoch in the Test context. | |||
| # the CLI parser prevents this argument from existing without the 'reproduce' arg | |||
| elif self.args.epoch: | |||
There was a problem hiding this comment.
Hm, couldn't we do this from outside of the context by mocking the epoch? Unless it's much more complex I would prefer not to add test specific code in the normal code.
tests/context.py
Outdated
Comment on lines
40
to
41
| TEST_ARGS.epoch = epoch | ||
| context = Context(TEST_ARGS) |
There was a problem hiding this comment.
Adding to what I mentioned above, didn't test it though.
Suggested change
| TEST_ARGS.epoch = epoch | |
| context = Context(TEST_ARGS) | |
| context = Context(TEST_ARGS) | |
| context.epoch = epoch | |
| context.epoch_dir = epoch | |
| context.epoch_datetime = datetime.utcfromtimestamp(int(epoch)) |
| @@ -48,7 +48,10 @@ def __init__(self, args): | |||
| self.epoch_dir = str(int(utc_time_now)) | |||
| self.epoch_datetime = datetime.utcfromtimestamp(int(utc_time_now)) | |||
|
|
|||
| cwd = os.getcwd() | |||
| if hasattr(self.args, 'cwd'): | |||
There was a problem hiding this comment.
Hm, I don't see what this is needed for.
|
Needs rebase now that #47 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial tests for RPKI parsing: check that duplicates, incompletes, ROA type, and invalids are parsed correctly. Mostly, setting up a test Context and adjusting some setup.
Includes a RPKI fixture CSV and handles casting it to a
rpki_raw.jsonfile as expected by the parsing code.rebased on #47