Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ticker Search #5

Merged
merged 7 commits into from
Jan 4, 2025
Merged

Added Ticker Search #5

merged 7 commits into from
Jan 4, 2025

Conversation

aheschl1
Copy link
Contributor

@aheschl1 aheschl1 commented Jan 2, 2025

This pull request includes several changes to the alphavantage project, focusing on adding functionality for retrieving ticker symbols and parsing time formats. The most important changes include the addition of a new module for handling ticker symbols, updates to the client to support ticker symbol searches, and new parsing functions for time formats.

New functionality:

  • src/tickers.rs: Added a new module to handle ticker symbol searches, including the SearchResults and Entry structs, and the parser module for parsing search results.

Client updates:

  • src/client.rs: Updated the client to include a new method get_tickers for retrieving ticker symbols that match a specified query.
  • src/client.rs: Modified imports to include the new tickers module.

Parsing improvements:

Configuration updates:

  • Cargo.toml: Updated the package version from 0.7.0 to 0.7.1.

Test additions:

  • tests/json/ticker_search_tesco.json, tests/json/ticker_search_tencent.json: Added new JSON test files for ticker symbol search results. [1] [2]

@asmarques
Copy link
Owner

Looks good. The only thing I would add is an implementation of get_tickers in blocking.rs to maintain feature parity between sync and async clients.

@aheschl1
Copy link
Contributor Author

aheschl1 commented Jan 4, 2025

Added it to blocking.rs in new a commit

@asmarques asmarques merged commit 3f55e74 into asmarques:master Jan 4, 2025
2 of 4 checks passed
@asmarques
Copy link
Owner

Thanks, I have now published v0.7.1 with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants