Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translations - German #126

Open
gianklug opened this issue Aug 6, 2022 · 4 comments
Open

Add translations - German #126

gianklug opened this issue Aug 6, 2022 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone
Version 1

Comments

@gianklug
Copy link

gianklug commented Aug 6, 2022

Is there already support for different languages? I'd be happy to provide german translations.
@gianklug gianklug added the triage label Aug 6, 2022
@asosnovsky asosnovsky added enhancement Improvement on an existing feature and removed triage labels Aug 6, 2022
@asosnovsky asosnovsky moved this to Triage in Shortumations Roadmap Aug 6, 2022
@asosnovsky asosnovsky added this to the Version 1 milestone Aug 6, 2022
@asosnovsky
Copy link
Owner

This may take some time to do right, I currently didn't implement any internationalisation yet.

@asosnovsky asosnovsky added the good first issue Good for newcomers label Aug 6, 2022
@asosnovsky asosnovsky added the ui label Aug 14, 2022
@asosnovsky asosnovsky moved this from Triage to Todo in Shortumations Roadmap Aug 18, 2022
@asosnovsky
Copy link
Owner

Some thoughts on this. I don't think we need a library or anything.

Just need to collect all the texts into a single json file and use a hook+provider to serve the json. Ideally the jsons will leave in the api and be retrieved via api calls. This way we can set an environment variable that would be configured by the user for this.

@asosnovsky asosnovsky added the help wanted Extra attention is needed label Aug 19, 2022
@asosnovsky asosnovsky mentioned this issue Aug 19, 2022
Open
@asosnovsky
Copy link
Owner

In relation to #89

Need to probably have some sort of templating for node description. Although this can be done on a second iteration on this. First whoever picks this up should focus on providing a way to translate the easy stuff like "delete automation" etc

@asosnovsky asosnovsky moved this from Todo to In Progress in Shortumations Roadmap Aug 27, 2022
@asosnovsky
Copy link
Owner

@gianklug added translations ability now.
Take a look at this PR for adding new translations :) #155

@asosnovsky asosnovsky changed the title Add translations Add translations - German Sep 1, 2022
@asosnovsky asosnovsky removed enhancement Improvement on an existing feature ui labels Sep 1, 2022
@asosnovsky asosnovsky moved this from In Progress to Backlog in Shortumations Roadmap Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
Shortumations Roadmap
Status: Backlog
Milestone
Version 1
Development

No branches or pull requests
2 participants
@asosnovsky @gianklug