Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better description generation for multilingual #89

Open
asosnovsky opened this issue Jul 22, 2022 · 1 comment
Open

Better description generation for multilingual #89

asosnovsky opened this issue Jul 22, 2022 · 1 comment
Labels
enhancement Improvement on an existing feature good first issue Good for newcomers ui
Milestone
Version 1

Comments

@asosnovsky
Copy link
Owner

asosnovsky commented Jul 22, 2022 •
edited
Loading

  • Not all node types have descriptions. I also haven't had the time to compile a full list, but bellow is some of them.
  • Currently there is no multilingual support

In general need to make sure all cases look clean and valid.

Triggers
...

Conditions

  • numeric_state

Actions

  • service calls

Related code

Function: https://github.com/asosnovsky/Shortumation/blob/main/webapp/src/utils/formatting.tsx#L27

Tests:

https://github.com/asosnovsky/Shortumation/blob/main/webapp/src/utils/formatting.test.ts
@asosnovsky asosnovsky added this to the Version 1 milestone Jul 22, 2022
@asosnovsky asosnovsky added the enhancement Improvement on an existing feature label Jul 22, 2022
@asosnovsky asosnovsky mentioned this issue Jul 22, 2022
Closed
@asosnovsky asosnovsky moved this from Triage to Backlog in Shortumations Roadmap Jul 22, 2022
@asosnovsky asosnovsky changed the title Better description generation for Better description generation Jul 22, 2022
@asosnovsky asosnovsky moved this from Backlog to Todo in Shortumations Roadmap Jul 22, 2022
@asosnovsky asosnovsky added the good first issue Good for newcomers label Jul 22, 2022
@asosnovsky asosnovsky moved this from Todo to Backlog in Shortumations Roadmap Jul 26, 2022
@asosnovsky asosnovsky moved this from Backlog to Triage in Shortumations Roadmap Aug 14, 2022
@asosnovsky asosnovsky moved this from Triage to Todo in Shortumations Roadmap Aug 18, 2022
@asosnovsky asosnovsky added the ui label Aug 19, 2022
@asosnovsky
Copy link
Owner Author

Also relating this to #126 need to think of how translations would fit this idea...

@asosnovsky asosnovsky mentioned this issue Aug 19, 2022
Open
@asosnovsky asosnovsky changed the title Better description generation Better description generation for multilingual Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement on an existing feature good first issue Good for newcomers ui
Projects
Shortumations Roadmap
Status: Todo
Milestone
Version 1
Development

No branches or pull requests
1 participant
@asosnovsky