Keep whitespace before imports #370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be compatible with black/ruff again.
for more information, see https://pre-commit.ci
|
no thanks, this has been consistent since 2014 and I'm not changing it |
yujinyuz
added a commit
to yujinyuz/django-as-a-package-layout-template
that referenced
this pull request
Apr 6, 2024
I'm glad that I discovered this issue sooner. I really liked reorder-python-imports but it was impossible to make it work with ruff and/or black. The one small issue I had was ruff was adding a new line below a docstring. While reorder-python-imports removes the new line. For context: - asottile/reorder-python-imports#370 - asottile/reorder-python-imports#366 - psf/black#4175
miguelinux
added a commit
to miguelinux/reorder-python-imports
that referenced
this pull request
Apr 14, 2024
This commits comes from * asottile#370 * psf/black#4175 (comment) because * asottile#367 * asottile#366 * psf/black#4175 Suggested-by: Achim Herwig <[email protected]>
miguelinux
added a commit
to miguelinux/reorder-python-imports
that referenced
this pull request
Sep 21, 2024
This commits comes from * asottile#370 * psf/black#4175 (comment) because * asottile#367 * asottile#366 * psf/black#4175 Suggested-by: Achim Herwig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #366
Makes reorder-python-imports compatible again with newer black and ruff versions. I'm quite indifferent to the actual formatting change and I'm not happy with the attitude of the black maintainers . But on the other hand, I don't see a point in fighting windmills and after ruff picked up the formatting change, I don't see a chance to go back.