Skip to content

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Oct 10, 2025

Sometimes the watchman initialization is slow such as when the directory needs to be re-indexed. There is no reason to block the initial bazel run --norun while waiting for watchman to initialize.

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • Manual testing; run --watch

@aspect-workflows
Copy link

aspect-workflows bot commented Oct 10, 2025

Test

11 test targets passed

Targets
//integration_tests/aspect:configure_test [k8-fastbuild] 1m 52s
//integration_tests/aspect:flags_test [k8-fastbuild]     2m 50s
//integration_tests/aspect:help_test [k8-fastbuild]      1m 48s
//integration_tests/aspect:hints_test [k8-fastbuild]     1m 46s
//integration_tests/aspect:info_test [k8-fastbuild]      1m 31s
//integration_tests/aspect:init_test [k8-fastbuild]      40s
//integration_tests/aspect:lint_test [k8-fastbuild]      1m 1s
//integration_tests/aspect:reenter_test [k8-fastbuild]   21s
//integration_tests/aspect:run_test [k8-fastbuild]       1m 17s
//integration_tests/aspect:version_test [k8-fastbuild]   1m 25s
//pkg/aspect/run:run_test [k8-fastbuild]                 117ms

Total test execution time was 14m 34s. 99 tests (90.0%) were fully cached saving 10s.


Buildifier

@jbedard jbedard requested a review from thesayyn October 10, 2025 18:52
@jbedard jbedard marked this pull request as ready for review October 10, 2025 18:52
@jbedard jbedard merged commit 72ba3ff into main Oct 15, 2025
3 checks passed
@jbedard jbedard deleted the watch-sooner branch October 15, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants