fix: ensure gazelle config overrides are local (#2638)

The change to add custom targets caused this issue. The inherited
targets configuration was not deep cloned, so modifications to the
targets configurations would modify the config of parent BUILDs.

<!-- Delete this comment! Follow our PR template instructions:
https://github.com/aspect-build/.github/blob/main/pull_requests.md -->

### Type of change

- Bug fix (change which fixes an issue)

### Test plan

- New test cases added

GitOrigin-RevId: bba27992671afa344077b8ef40be142f583075fa

gazelle/js/config.go

@@ -185,6 +185,15 @@ func newRootConfig() *JsGazelleConfig {
 	}
 }
 
+func (g *TargetGroup) copy() *TargetGroup {
+	return &TargetGroup{
+		name:           g.name,
+		customSources:  g.customSources[:],
+		defaultSources: g.defaultSources,
+		testonly:       g.testonly,
+	}
+}
+
 // NewChild creates a new child JsGazelleConfig. It inherits desired values from the
 // current JsGazelleConfig and sets itself as the parent to the child.
 func (c *JsGazelleConfig) NewChild(childPath string) *JsGazelleConfig {
@@ -194,8 +203,14 @@ func (c *JsGazelleConfig) NewChild(childPath string) *JsGazelleConfig {
 	cCopy.excludes = make([]string, 0)
 	cCopy.ignoreDependencies = make([]string, 0)
 	cCopy.resolves = linkedhashmap.New()
-	cCopy.targets = c.targets[:]
 
+	// Copy the targets, any modifications will be local.
+	cCopy.targets = make([]*TargetGroup, 0, len(c.targets))
+	for _, target := range c.targets {
+		cCopy.targets = append(cCopy.targets, target.copy())
+	}
+
+	// Copy the overrides, any modifications will be local.
 	cCopy.targetNamingOverrides = make(map[string]string)
 	for k, v := range c.targetNamingOverrides {
 		cCopy.targetNamingOverrides[k] = v

gazelle/js/tests/simple_globs/BUILD.out

@@ -7,10 +7,7 @@ load("@aspect_rules_ts//ts:defs.bzl", "ts_project")
 
 ts_project(
     name = "simple_globs",
-    srcs = [
-        "other.ts",
-        "srcs/main.ts",
-    ],
+    srcs = ["srcs/main.ts"],
 )
 
 ts_project(

gazelle/js/tests/simple_globs/e2e/BUILD.in

@@ -0,0 +1,5 @@
+# Modify the globs within a subdirectory.
+# Should not effect the js_test_files of parent/sibling directories.
+# Example bug: https://github.com/sourcegraph/sourcegraph/commit/87a70c7c1ff0328540af1b2d77eb3b035b41b1d3
+
+# gazelle:js_test_files **/*.{ts,tsx}

gazelle/js/tests/simple_globs/e2e/BUILD.out

@@ -0,0 +1,16 @@
+load("@aspect_rules_ts//ts:defs.bzl", "ts_project")
+
+# Modify the globs within a subdirectory.
+# Should not effect the js_test_files of parent/sibling directories.
+# Example bug: https://github.com/sourcegraph/sourcegraph/commit/87a70c7c1ff0328540af1b2d77eb3b035b41b1d3
+
+# gazelle:js_test_files **/*.{ts,tsx}
+
+ts_project(
+    name = "e2e_tests",
+    testonly = True,
+    srcs = [
+        "a.ts",
+        "r.ts",
+    ],
+)