Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add bazel8 ci #1929

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: add bazel8 ci #1929

wants to merge 1 commit into from
+41 −8

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Oct 1, 2024 •
edited
Loading

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Oct 1, 2024 •
edited
Loading

Test

⚠️ Buildkite build #6828 failed.

Failed tests (1) 
//.github/workflows:update_aspect_bazelrc_presets_0_test [k8-fastbuild]                 🔗

💡 To reproduce the test failures, run

bazel test //.github/workflows:update_aspect_bazelrc_presets_0_test

Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 857ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 503ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 7s.

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 820ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 1s.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 34ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 34ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 171ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 129ms.

Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 503ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 222ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 131ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 131ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 590ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

40 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

12 tests (100.0%) were fully cached saving 2s.

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 474ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 470ms.

Test

e2e/runfiles

⚠️ Buildkite build #6828 failed.

Failed tests (1) 
//:runfiles [k8-fastbuild]                                                              🔗

💡 To reproduce the test failures, run

bazel test //:runfiles

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 199ms.

Buildifier      Format

@jbedard jbedard force-pushed the bazel-8 branch 4 times, most recently from c2bfabf to 7dac2b5 Compare October 4, 2024 22:23
@jbedard jbedard marked this pull request as ready for review October 4, 2024 22:41
@jbedard jbedard requested a review from gregmagolan October 4, 2024 23:28
@jbedard jbedard force-pushed the bazel-8 branch 2 times, most recently from 9ffc41e to f0aadf8 Compare October 17, 2024 03:55
@jbedard jbedard force-pushed the bazel-8 branch 5 times, most recently from c881939 to ed8fe32 Compare October 21, 2024 18:29
@jbedard jbedard marked this pull request as draft October 21, 2024 18:29
@jbedard jbedard force-pushed the bazel-8 branch 4 times, most recently from e75d9c8 to 462855f Compare October 21, 2024 18:48
jbedard
jbedard commented Oct 21, 2024
View reviewed changes
MODULE.bazel
@@ -9,7 +9,7 @@ module(

# Lower-bounds (minimum) versions for direct runtime dependencies.
# Do not bump these unless rules_js requires a newer version to function.
bazel_dep(name = "aspect_bazel_lib", version = "2.8.1")
bazel_dep(name = "aspect_bazel_lib", version = "2.9.2")
Copy link
Member Author

@jbedard jbedard Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required for the bazelrc changes, specifically for bazel-contrib/bazel-lib@7d901b7

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, can merge that as a pre-factor if it helps get this green and landed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @alexeagle