Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: port pytest_test macro #401

Merged
merged 1 commit into from
Feb 13, 2025
Merged

feat: port pytest_test macro #401

merged 1 commit into from
Feb 13, 2025

Conversation

alexeagle
Copy link
Member

Comes from caseyduquettesc/rules_python_pytest#13 It's much easier to properly gazelle-generate a BUILD file in this shape rather than the awkward way you're forced to hold our py_pytest_main.

@alexeagle alexeagle requested review from jbedard and mattem October 3, 2024 16:16
alexeagle
alexeagle commented Oct 3, 2024
View reviewed changes
pytest/pytest_shim.py Outdated Show resolved Hide resolved
mattem
mattem reviewed Oct 3, 2024
View reviewed changes
pytest/pytest_shim.py Outdated Show resolved Hide resolved
pytest/pytest_shim.py Outdated Show resolved Hide resolved
pytest/defs.bzl Outdated Show resolved Hide resolved
pytest/defs.bzl Outdated Show resolved Hide resolved
pytest/defs.bzl Outdated Show resolved Hide resolved
pytest/defs.bzl Outdated Show resolved Hide resolved
pytest/defs.bzl Outdated Show resolved Hide resolved
pytest/pytest_shim.py Outdated Show resolved Hide resolved
@alexeagle
Copy link
Member Author

alexeagle commented Oct 3, 2024 •
edited
Loading

I have very little time to prepare a talk for Monday and I think you're expecting a higher level of polish than Casey had, so I'm going to try the bazelbuild/rules_python#2044 approach instead

@alexeagle alexeagle mentioned this pull request Oct 4, 2024
Open
@alexeagle alexeagle mentioned this pull request Jan 21, 2025
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

e2e/use_release folder: LCOV of commit 826d536 during CI #1680

Summary coverage rate:
  lines......: 100.0% (2 of 2 lines)
  functions..: 100.0% (1 of 1 function)
  branches...: no data found

Files changed coverage rate: n/a

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Jan 28, 2025 •
edited
Loading

Test

All tests were cache hits

30 tests (100.0%) were fully cached saving 51s.

@alexeagle alexeagle requested a review from thesayyn January 29, 2025 04:08
@alexeagle
feat: py_test macro generates a py_pytest_main
826d536 
Provides much-needed syntax sugar for this common case.
@alexeagle alexeagle merged commit 6ad4667 into main Feb 13, 2025
16 checks passed
@alexeagle alexeagle deleted the pytest branch February 13, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattem mattem mattem left review comments

@caseyduquettesc caseyduquettesc caseyduquettesc left review comments

@thesayyn thesayyn thesayyn approved these changes

@jbedard jbedard Awaiting requested review from jbedard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexeagle @mattem @caseyduquettesc @thesayyn