Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "example: Add example for pybind11" #444

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

alexeagle
Copy link
Member

Reverts #375

Broke the main branch.

As noted earlier we don't have the right branch protections on this repo to prevent merging red PRs. @mattem please fix it or grant me permissions so I can fix it.

@alexeagle alexeagle requested a review from mattem November 20, 2024 15:20
@mattem
Copy link
Collaborator

mattem commented Nov 20, 2024

Can you add the check to CI that shows the overall status of the matrix? Adding the individual status checks to the branch protection isn't good enough. The rest of the branch protection settings look correct.

@alexeagle
Copy link
Member Author

sure: #445

@mattem mattem enabled auto-merge (squash) November 20, 2024 15:38
@mattem mattem merged commit aae7c24 into main Nov 20, 2024
11 checks passed
@mattem mattem deleted the revert-375-pybind11-example branch November 20, 2024 15:39
alexeagle added a commit to alexeagle/rules_py that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants