New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Py interface cleanup #122

Merged

smartgoo merged 4 commits into aspectron:python from smartgoo:py-interface-cleanup

Nov 3, 2024

Collaborator

smartgoo commented Nov 3, 2024 •

edited

Loading

String vs &str in functions exposed
Replace all Result with PyResult
Prop errors where possible
map_err() cleanup
Remove unwrap() where possible
RPC subscription print python stack trace if execution of python callback from Rust yields exception

smartgoo added 4 commits

November 2, 2024 16:20


          String vs. &str

cfe84e7


          result type and bubble where possible

ca69b0c


          rpc result type, subscription callback print stack trace

e064773


          pubkey

42fee43

smartgoo merged commit 4770a70 into aspectron:python

6 checks passed

smartgoo deleted the py-interface-cleanup branch

November 3, 2024 21:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet