-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated to Asphalt 5 #48
base: master
Are you sure you want to change the base?
Conversation
@@ -32,25 +34,26 @@ def __init__( | |||
self.subject = subject | |||
self.attachment = attachment | |||
|
|||
async def start(self, ctx: Context) -> None: | |||
async def start(self) -> None: | |||
self.add_component( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be moved to __init__
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made this a data class and moved this code to __post_init__()
.
@@ -31,18 +33,19 @@ def __init__( | |||
self.subject = subject | |||
self.body = body | |||
|
|||
async def start(self, ctx: Context) -> None: | |||
async def start(self) -> None: | |||
self.add_component( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above.
No description provided.