Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated to Asphalt 5 #48

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Migrated to Asphalt 5 #48

wants to merge 22 commits into from

Conversation

agronholm
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Dec 30, 2024

Coverage Status

coverage: 99.51% (-0.5%) from 100.0%
when pulling 439c7c0 on asphalt5
into a4ab9ab on master.

@@ -32,25 +34,26 @@ def __init__(
self.subject = subject
self.attachment = attachment

async def start(self, ctx: Context) -> None:
async def start(self) -> None:
self.add_component(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be moved to __init__?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made this a data class and moved this code to __post_init__().

@@ -31,18 +33,19 @@ def __init__(
self.subject = subject
self.body = body

async def start(self, ctx: Context) -> None:
async def start(self) -> None:
self.add_component(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants