Shallow copy resources and resource factories instead of using context chain lookup #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I may need to validate this against my commercial app to make sure this doesn't actually break any major design patterns we're using. |
Co-authored-by: David Brochart <[email protected]>
davidbrochart
approved these changes
Oct 21, 2024
This is to make sure that contexts are not closed out of order.
…onent context instance
davidbrochart
approved these changes
Dec 12, 2024
Co-authored-by: David Brochart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents background tasks from having access to resources that would be torn down before the tasks themselves.