Use shellwords for .stowrc parsing
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `shellwords` to parse `.stowrc` files from `Text::ParseWords` - Add test for `.stowrc` parsing with quotes - Add `stow directory` to `tmp-testing-trees` for testing This change allows `.stowrc` arguments to be parsed similar to shell arguments, where quotes can be used to group an argument with spaces. However, this change affects the behavior in --ignore, --defer, --override. (?^:$HOME\z) (?^:\A$HOME) (?^:\A$HOME)
Previously the \A and \z anchoring for --ignore / --override / --defer
was being applied without wrapping the user-specified regexp in
parentheses, so if it was something like bin|man then the anchor would
only apply to one half of those two paths. So add parentheses, and
also change from qr() to qr{} syntax to visually differentiate between
regexp boundaries and parentheses inside the regexp.
|
Awesome, thanks a lot! I think I've fixed the concerns you highlighted now - take a look and let me know what you think? |
|
Looks great, thank you so much! |
aspiers
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shellwordsto parse.stowrcfiles fromText::ParseWords.stowrcparsing with quotesstow directorytotmp-testing-treesfor testingThis change allows
.stowrcarguments to be parsed similar to shell arguments, where quotes can be used to group an argument with spaces.However, this change affects the behavior in --ignore, --defer, --override.
--ignore=$HOME => (?^:$HOME\z)
--defer=$HOME => (?^:\A$HOME)
--override=$HOME => (?^:\A$HOME)
Hi, this PR is in regards to #15. Other than the tests mentioned (
rc_options.t, Test that environment variable expansion is applied. for ignore, defer, and override), everything passes.I am using
shell_wordsbut I also did it with `parse_line(" ", 0, $line) and it had the same effect of breaking that test.My two concerns are:
tmp-testing-treesfor just one test.Fixes #15.