Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asirota/add issue template #99

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

asirota
Copy link
Member

@asirota asirota commented Nov 2, 2024

Pull Request

What changed?

added ISSUE_TEMPLATE for GitHub

Why did it change?

make it easier for new contributors to file bugs and feature requests

Did you fix any specific issues?

fixed readme.txt license to GPLv2
#100

CERTIFICATION

By opening this pull request, I do agree to abide by
the CODE OF CONDUCT and be bound by the terms
of the Contribution Guidelines in effect on the date and time
of my contribution as proven by the
revision information in GitHub. I also agree that any previous contributions shall be deemed subject to the terms of the
version in effect on the date and time of this pull request, or any future revisions for pull requests I may submit.
Further, I certify that this work is my own, is original, does not violate the intellectual property of any other person
or entity, and I am not violating any license agreements or contracts I have with any person or entity. Finally, I agree
that this code may be licensed under any license deemed appropraite by AspirePress, including but not
limited to open source, closed source, proprietary or custom licenses, and that such license terms neither violate my
rights or my copyright to this code.

helps new GitHub contributors file better bugs or feature requests

Signed-off-by: Alex Sirota <[email protected]>
Signed-off-by: Alex Sirota <[email protected]>
@asirota asirota added the documentation Improvements or additions to documentation label Nov 2, 2024
@asirota asirota added this to the Phase 1 milestone Nov 2, 2024
@asirota asirota requested a review from namithj November 2, 2024 14:10
@asirota asirota self-assigned this Nov 2, 2024
@costdev
Copy link
Contributor

costdev commented Nov 2, 2024

The plugin file's license is GPLv3 or later. How come the license is changed to GPLv2 here?

Think it's important that we note the reasoning for license changes so that everyone's aware, in agreement, etc.

@afragen
Copy link

afragen commented Nov 2, 2024

May want to consider using the Test Reports plugin for some of this templating.

@asirota
Copy link
Member Author

asirota commented Nov 2, 2024

@costdev because it's gpl2. The readme.txt was a typo. It's not gpl3

@afragen I have no idea what you are describing. Link please ?

I'm using basic GitHub functions for the templates.

@costdev
Copy link
Contributor

costdev commented Nov 2, 2024

@asirota aspire-plugin.php and composer.json (therefore composer.lock - update locally after changing .json with composer update) state GPLv3 or later

@asirota
Copy link
Member Author

asirota commented Nov 2, 2024

That's wrong. @sarah-savage stated it is gplv2.

We should really enforce this at the code lint level somehow. Or phpcs.

@afragen
Copy link

afragen commented Nov 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants