fixed various issues per @anurse

aspnet · Nov 1, 2018 · 5e5111a · 5e5111a
1 parent 92a54f6
commit 5e5111a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/PullRequestR/android/app/build.gradle b/PullRequestR/android/app/build.gradle
@@ -29,7 +29,8 @@ dependencies {
     testImplementation 'junit:junit:4.12'
     androidTestImplementation 'com.android.support.test:runner:1.0.2'
     androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'
-    implementation group: 'com.microsoft.signalr', name: 'signalr', version: '1.0.0-preview4-t000'
+    implementation 'com.microsoft.signalr:signalr:1.0.0-preview3-35501'
+    implementation 'io.reactivex.rxjava2:rxjava:2.2.2'
     implementation group: 'org.slf4j', name: 'slf4j-android', version: '1.7.7'
     implementation 'com.squareup.picasso:picasso:2.71828'
 }
diff --git a/PullRequestR/android/app/src/main/java/com/example/pullrequestr/MainActivity.java b/PullRequestR/android/app/src/main/java/com/example/pullrequestr/MainActivity.java
@@ -30,6 +30,8 @@ protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
         setContentView(R.layout.activity_main);
 
+        // This URL does NOT need to be suffixed with the "negotiate" endpoint, 
+        // the /api endpoint is correct. 
         String url = "https://YOUR-FUNCTION-URI.azurewebsites.net/api";
         PullRequestAdapter adapter = new PullRequestAdapter(this, pullRequests);
         ListView lvItems = (ListView)findViewById(R.id.lvPullRequestList);

diff --git a/PullRequestR/android/build.gradle b/PullRequestR/android/build.gradle
@@ -19,9 +19,6 @@ allprojects {
     repositories {
         google()
         jcenter()
-        maven {
-            url 'https://www.myget.org/F/ping-verify/maven/'
-        }
     }
 }
 

diff --git a/PullRequestR/function-dotnet/Negotiate.cs b/PullRequestR/function-dotnet/Negotiate.cs
@@ -13,6 +13,9 @@
 
 namespace Company.Function
 {
+    // The class AND the value of the FunctionName parameter must
+    // both be set to "negotiate" as the SignalR client expects
+    // to call this specific endpoint. 
     public static class negotiate
     {
         [FunctionName("negotiate")]