Fix button.type = 'submit' and support button.type = 'reset' - Fix #1190

src/document.js

@@ -166,8 +166,8 @@ function setupWindow(window, args) {
   window.FormData =       Fetch.FormData;
 
   // Base-64 encoding/decoding
-  window.atob = (string)=> new Buffer(string, 'base64').toString('binary');
-  window.btoa = (string)=> new Buffer(string, 'binary').toString('base64');
+  window.atob = (string)=> Buffer.from(string, 'base64').toString('binary');
+  window.btoa = (string)=> Buffer.from(string, 'binary').toString('base64');
 
   // Constructor for XHLHttpRequest
   window.XMLHttpRequest = XMLHttpRequest.bind(null, window);

src/dom/forms.js

@@ -244,9 +244,19 @@ DOM.HTMLButtonElement.prototype._click = function(event) {
   if (button.getAttribute('disabled'))
     return false;
 
+  const buttonType = button.getAttribute('type');
+  if (buttonType === 'button')
+    return;
+
   const form = button.form;
-  if (form)
+  if (form) {
+    if (buttonType === 'reset') {
+      input.form.reset();
+      return;
+    }
+
     return form._dispatchSubmitEvent(button);
+  }
 };
 
 DOM.HTMLInputElement.prototype._click = function(event) {

src/fetch.js

@@ -294,7 +294,7 @@ class Body {
       return null;
     // When Response has no body, we get stream that's no longer readable
     if (!this._stream.readable)
-      return new Buffer('');
+      return Buffer.from('');
 
     const decompressed = decompressStream(this._stream, this.headers);
 

src/pipeline.js

@@ -173,7 +173,7 @@ class Pipeline extends Array {
     const { username, password } = authenticate;
     if (username && password) {
       browser.log(`Authenticating as ${username}:${password}`);
-      const base64 = new Buffer(`${username}:${password}`).toString('base64');
+      const base64 = Buffer.from(`${username}:${password}`).toString('base64');
       request.headers.set('authorization',  `Basic ${base64}`);
     }
   }

test/websocket_test.js

@@ -65,7 +65,7 @@ describe('WebSockets', function() {
     });
 
     it('should be possible', function() {
-      browser.assert.text('#ws-url', 'ws://example.com:3004');
+      browser.assert.text('#ws-url', 'ws://example.com:3004/');
     });
     it('should raise open event after connecting', function() {
       assert.equal(prompts[0], 'open');