Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after update from v0.2.3 to v0.2.5, #compose not rendering {{{@conent}}}? #26

Open
ghost opened this issue Apr 20, 2015 · 2 comments
Open

Comments

@ghost
Copy link

ghost commented Apr 20, 2015

I was able to render multiple partials to a single page using handlebars-helper-compose prior to [email protected].

E.g. this worked fine in my page.hbs, where src/templates/partials had multiple .hbs partials:
{{#compose cwd="src/templates/partials" src="*.hbs"}}
{{{@content}}}
{{/compose}}

I can still render the multiple partials if I revert the sub package for assemble to [email protected] (in my-project-folder/node_modules/assemble/node_modules/assemble-handlebars

@title, @basename, @filename etc all seem to work still.
I can even log out the @content markup {{log @content}}, but when trying to render it, no markup is injected.

I have deleted my main node_modules folder and reinstalled all modules (npm install), but that didn't seem to help.

Version info:
{{{@content}}} works with:
[email protected], [email protected] and [email protected].
Not working as expected (for me) with:
[email protected], [email protected] and [email protected].
Node: v0.10.20

Is there a slightly different way of using the compose helper since the latest update to assemble-handlebars?

Or, if you can't reproduce, could you offer suggestions?

(apologies if this should be logged on the handlebars-helper-compose project, but there didn't seem to be any changes to that code base recently)

Thanks

@doowb
Copy link
Member

doowb commented Apr 20, 2015

Thanks for pointing this out. There might be a change in handlebars 3 that is affecting the compose helper. Do you have a repo with the failing code that we can take a look at?

@ghost
Copy link
Author

ghost commented Apr 21, 2015

I created two public repos for testing:
https://github.com/nuls1/compose-a-test.git
https://github.com/nuls1/compose-b-test.git

The read me on test a has the most info, but in summary:
When using {{{@content}}} with handlebars-helper-compose...
Test a works where [email protected] is used.
Test b fails where [email protected] is used.
Test a and b are identical other than that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant