fix(harness)!: Future proof the API #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking to offer more options on `Data`, so rather than `Case` having to carry it all, `Data` can.
32 tasks
epage
added a commit
to epage/snapbox
that referenced
this pull request
May 17, 2024
This builds on and mirrors the extensibility work that was done in `snapbox` where `Data::read_from` and `Data::raw` can be used to override default behavior. Cherry pick 30a9b78 (assert-rs#274) Cherry pick 94e87ba (assert-rs#283)
epage
added a commit
to epage/snapbox
that referenced
this pull request
May 17, 2024
epage
added a commit
to epage/snapbox
that referenced
this pull request
May 17, 2024
epage
added a commit
to epage/snapbox
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize the API to allow more flexibility in the future