Skip to content

Commit

Permalink
Set minimum boost version to 1.77.0 (facebookincubator#9094)
Browse files Browse the repository at this point in the history
Summary:
This [commit](facebookincubator@6dba462) introduces some code to use a boost API: `boost::uuids::to_chars`, which is available since boost 1.77.0 (see [boost commit](boostorg/uuid@eaa4be7)). So I'm proposing to change the minimum version to 1.77.0.

Post related PR:
facebookincubator#8679

Pull Request resolved: facebookincubator#9094

Reviewed By: xiaoxmeng

Differential Revision: D56051595

Pulled By: kgpai

fbshipit-source-id: d1f5d78c45de203041ff865dad50d67abc7d84fb
  • Loading branch information
PHILO-HE authored and facebook-github-bot committed Apr 12, 2024
1 parent 80ef831 commit 7a36070
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CMake/resolve_dependency_modules/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ by Velox. See details on bundling below.
| zstd | default | No |
| openssl | default | No |
| protobuf | 21 (exact) | Yes |
| boost | 1.66.0 | Yes |
| boost | 1.77.0 | Yes |
| flex | 2.5.13 | No |
| bison | 3.0.4 | No |
| cmake | 3.14 | No |
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ set(BOOST_INCLUDE_LIBRARIES
thread)

set_source(Boost)
resolve_dependency(Boost 1.66.0 COMPONENTS ${BOOST_INCLUDE_LIBRARIES})
resolve_dependency(Boost 1.77.0 COMPONENTS ${BOOST_INCLUDE_LIBRARIES})

# Range-v3 will be enable when the codegen code actually lands keeping it here
# for reference. find_package(range-v3)
Expand Down

0 comments on commit 7a36070

Please sign in to comment.