chore(infra): move tests folder to top level

.github/workflows/ci.yml

@@ -18,7 +18,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version-file: '.nvmrc'
       - name: Install sg
         run: npm install -g @ast-grep/cli
       - name: Install deps

.github/workflows/publish.yml

@@ -17,7 +17,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version-file: '.nvmrc'
       - name: Install deps
         run: npm install
       - name: Install vsce

scripts/test/integration-test.cjs

@@ -2,6 +2,8 @@ const path = require('node:path')
 const Mocha = require('mocha')
 const glob = require('glob')
 
+const TESTS_ROOT = path.join(__dirname, '../../tests')
+
 async function run() {
   await import('tsx')
   // Create the mocha test
@@ -13,7 +15,7 @@ async function run() {
   })
 
   /**
-    Before any other tests, run the testSetup.ts file 
+    Before any other tests, run the testSetup.ts file
     This will set up the test environment necessary for the other tests to run
   */
   mocha.addFile(path.join(__dirname, 'testSetup.ts'))
@@ -25,14 +27,13 @@ async function run() {
    * So you could play with sort order on the tests to investigate
    */
   try {
-    const testsRoot = path.join(__dirname, '../../src/test')
-    let files = await glob('**.test.ts', { cwd: testsRoot })
+    let files = await glob('**.test.ts', { cwd: TESTS_ROOT })
     // Add files to the test suite
     files.sort((a, b) => {
       return a.localeCompare(b)
     })
     files.forEach(f => {
-      mocha.addFile(path.resolve(testsRoot, f))
+      mocha.addFile(path.resolve(TESTS_ROOT, f))
     })
 
     return new Promise((resolve, reject) => {

scripts/test/testSetup.ts

@@ -1,4 +1,4 @@
-import { activate } from '../../src/test/utils'
+import { activate } from '../../tests/utils'
 /**
  * This initialization runs once, before the rest of the tests.
  * It is used to open the test fixture folder and activate the extension.

src/extension.ts

@@ -264,7 +264,7 @@ async function watchEditsToRestartLanguageClient(context: ExtensionContext) {
     try {
       // get the absolute URI to this relative path
       let configUri = Uri.file(
-        workspace.workspaceFolders![0].uri.fsPath + '/' + configPath
+        path.join(workspace.workspaceFolders![0].uri.fsPath, configPath)
       )
       // read the config file
       let configText = await workspace.fs.readFile(configUri)

src/test/fileModifications.test.ts → tests/fileModifications.test.ts

@@ -1,5 +1,6 @@
 import * as vscode from 'vscode'
 import * as yaml from 'js-yaml'
+import path from 'path'
 
 import {
   getDocUri,
@@ -8,16 +9,19 @@ import {
   assertDiagnosticsEqual
 } from './utils'
 
-const MAX_WAIT_TIME_FOR_UPDATE = 5000 // ms
-const MAX_WAIT_TIME_FOR_INITIAL_DIAGNOSTICS = 10000 // ms
+const MAX_WAIT_TIME_FOR_UPDATE = 10000 // ms
+const MAX_WAIT_TIME_FOR_INITIAL_DIAGNOSTICS = 15000 // ms
 
 const docUri = getDocUri('test.ts')
-const diagnosticss = getExpectedDiagnosticss()
+const diagnostics = getExpectedDiagnostics()
 
 async function writeNewRule() {
   let vscodeuri = vscode.Uri.file(
-    vscode.workspace.workspaceFolders![0].uri.fsPath +
-      '/rules/no-math-random.yml'
+    path.join(
+      vscode.workspace.workspaceFolders![0].uri.fsPath,
+      'rules',
+      'no-math-random.yml'
+    )
   )
   await vscode.workspace.fs.writeFile(
     vscodeuri,
@@ -34,14 +38,17 @@ note: no Math.random()`)
 }
 async function deleteNewRule() {
   let vscodeuri = vscode.Uri.file(
-    vscode.workspace.workspaceFolders![0].uri.fsPath +
-      '/rules/no-math-random.yml'
+    path.join(
+      vscode.workspace.workspaceFolders![0].uri.fsPath,
+      'rules',
+      'no-math-random.yml'
+    )
   )
   await vscode.workspace.fs.delete(vscodeuri)
 }
 async function setRuleDirs(newRuleDirs: string[]) {
   let vscodeuri = vscode.Uri.file(
-    vscode.workspace.workspaceFolders![0].uri.fsPath + '/sgconfig.yml'
+    path.join(vscode.workspace.workspaceFolders![0].uri.fsPath, 'sgconfig.yml')
   )
   let content = await vscode.workspace.fs.readFile(vscodeuri)
   let configText = new TextDecoder().decode(content)
@@ -62,7 +69,7 @@ suite('Should update when files change', () => {
     try {
       assertDiagnosticsEqual(
         vscode.languages.getDiagnostics(docUri),
-        diagnosticss[0]
+        diagnostics[0]
       )
     } catch (e) {
       console.warn(
@@ -79,7 +86,7 @@ suite('Should update when files change', () => {
       }
       assertDiagnosticsEqual(
         vscode.languages.getDiagnostics(docUri),
-        diagnosticss[0]
+        diagnostics[0]
       )
     }
   })
@@ -88,15 +95,15 @@ suite('Should update when files change', () => {
     await waitForDiagnosticChange(MAX_WAIT_TIME_FOR_UPDATE)
     assertDiagnosticsEqual(
       vscode.languages.getDiagnostics(docUri),
-      diagnosticss[1]
+      diagnostics[1]
     )
   })
   test('Update on rule deletion', async () => {
     deleteNewRule()
     await waitForDiagnosticChange(MAX_WAIT_TIME_FOR_UPDATE)
     assertDiagnosticsEqual(
       vscode.languages.getDiagnostics(docUri),
-      diagnosticss[2]
+      diagnostics[2]
     )
   })
   test('Update on ruleDirs change to nonexistent path', async () => {
@@ -109,7 +116,7 @@ suite('Should update when files change', () => {
     await waitForDiagnosticChange(MAX_WAIT_TIME_FOR_UPDATE)
     assertDiagnosticsEqual(
       vscode.languages.getDiagnostics(docUri),
-      diagnosticss[0]
+      diagnostics[0]
     )
   })
 })
@@ -120,7 +127,7 @@ function toRange(sLine: number, sChar: number, eLine: number, eChar: number) {
   return new vscode.Range(start, end)
 }
 
-function getExpectedDiagnosticss() {
+function getExpectedDiagnostics() {
   const full = [
     {
       message: 'No Math.random',

src/test/utils.ts → tests/utils.ts

@@ -5,6 +5,8 @@ import * as assert from 'assert'
 export let doc: vscode.TextDocument
 export let editor: vscode.TextEditor
 
+const FIXTURE_PATH = path.resolve(__dirname, '../fixture')
+
 /**
  * Prepare the vscode environment for testing by opening the fixture folder
  * and activating the extension.
@@ -15,9 +17,7 @@ export let editor: vscode.TextEditor
 export async function activate() {
   // The extensionId is `publisher.name` from package.json
   const ext = vscode.extensions.getExtension('ast-grep.ast-grep-vscode')!
-  const fixtureFolderUri = vscode.Uri.file(
-    path.resolve(__dirname, '../../fixture')
-  )
+  const fixtureFolderUri = vscode.Uri.file(FIXTURE_PATH)
   await ext.activate()
   try {
     // open ast-grep project to locate sgconfig.yml
@@ -118,7 +118,7 @@ async function sleep(ms: number) {
 }
 
 export const getDocPath = (p: string) => {
-  return path.resolve(__dirname, '../../fixture', p)
+  return path.resolve(FIXTURE_PATH, p)
 }
 export const getDocUri = (p: string) => {
   return vscode.Uri.file(getDocPath(p))

tsconfig.json

@@ -4,14 +4,14 @@
     "target": "es2020",
     "lib": ["es2020", "DOM"],
     "outDir": "out",
-    "rootDir": "src",
+    "rootDir": ".",
     "esModuleInterop": true,
     "forceConsistentCasingInFileNames": true,
     "strict": true,
     "sourceMap": true,
     "skipLibCheck": true,
     "jsx": "react-jsx"
   },
-  "include": ["src"],
+  "include": ["src", "tests"],
   "exclude": ["node_modules", ".vscode-test"]
 }