Fix memory corruption (marker was getting overflowed because #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some strings are 8 characters. With the null chararacter, it needed to be 9 chars. It was only 8. Also, fixed the non rw option.
|
Hi @jmailloux thank you for participating Please, check the latest v3.1 release. I was adding new features regarding generation output configuration flexibility and also stumbled with that problem. FindVersion is completely refactored, I believe that this issue fixed now. |
if the last message in the list was the biggest message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed memory corruption that was causing an abort when running this on MacOS. In FindVersion, marker was only 8 bytes. It needed to be 9 bytes because some strings were 8 characters long. That would make 9 bytes with the null terminator.
Also, fixed the no -rw option. Before, it would create 000, 001, ... folders, but all of the code folders would be in the output directory instead of the appropriate numbered directory.