refactor(RM): move delete_simple_trigger

Moves `delete_simple_trigger` to `exandra` and `ecto`

Signed-off-by: Luca Zaninotto <[email protected]>

apps/astarte_realm_management/lib/astarte_realm_management/engine.ex

@@ -770,8 +770,7 @@ defmodule Astarte.RealmManagement.Engine do
   def delete_trigger(realm_name, trigger_name) do
     _ = Logger.info("Going to delete trigger.", trigger_name: trigger_name, tag: "delete_trigger")
 
-    with {:ok, client} <- get_database_client(realm_name),
-         {:ok, trigger} <- Queries.retrieve_trigger(realm_name, trigger_name) do
+    with {:ok, trigger} <- Queries.retrieve_trigger(realm_name, trigger_name) do
       _ =
         Logger.info("Deleting trigger.",
           trigger_name: trigger_name,
@@ -781,10 +780,9 @@ defmodule Astarte.RealmManagement.Engine do
       delete_all_simple_triggers_succeeded =
         Enum.all?(trigger.simple_triggers_uuids, fn simple_trigger_uuid ->
           Queries.delete_simple_trigger(
-            client,
+            realm_name,
             trigger.trigger_uuid,
-            simple_trigger_uuid,
-            realm_name
+            simple_trigger_uuid
           ) == :ok
         end)
 

apps/astarte_realm_management/lib/astarte_realm_management/queries.ex

@@ -1112,39 +1112,35 @@ defmodule Astarte.RealmManagement.Queries do
     end
   end
 
-  def delete_simple_trigger(client, parent_trigger_uuid, simple_trigger_uuid, realm_name) do
+  def delete_simple_trigger(realm_name, parent_trigger_uuid, simple_trigger_uuid) do
     with %{object_uuid: object_id, object_type: object_type} <-
            retrieve_simple_trigger_astarte_ref(realm_name, simple_trigger_uuid) do
-      delete_simple_trigger_statement = """
-      DELETE FROM simple_triggers
-      WHERE object_id=:object_id AND object_type=:object_type AND
-            parent_trigger_id=:parent_trigger_id AND simple_trigger_id=:simple_trigger_id
-      """
+      keyspace = Realm.keyspace_name(realm_name)
 
       delete_simple_trigger_query =
-        DatabaseQuery.new()
-        |> DatabaseQuery.statement(delete_simple_trigger_statement)
-        |> DatabaseQuery.put(:object_id, object_id)
-        |> DatabaseQuery.put(:object_type, object_type)
-        |> DatabaseQuery.put(:parent_trigger_id, parent_trigger_uuid)
-        |> DatabaseQuery.put(:simple_trigger_id, simple_trigger_uuid)
+        from SimpleTrigger,
+          prefix: ^keyspace,
+          where: [
+            object_id: ^object_id,
+            object_type: ^object_type,
+            parent_trigger_id: ^parent_trigger_uuid,
+            simple_trigger_id: ^simple_trigger_uuid
+          ]
 
-      delete_astarte_ref_statement =
-        "DELETE FROM kv_store WHERE group='simple-triggers-by-uuid' AND key=:simple_trigger_uuid;"
+      simple_trigger_uuid =
+        simple_trigger_uuid
+        |> :uuid.uuid_to_string()
+        |> to_string()
 
       delete_astarte_ref_query =
-        DatabaseQuery.new()
-        |> DatabaseQuery.statement(delete_astarte_ref_statement)
-        |> DatabaseQuery.put(:simple_trigger_uuid, :uuid.uuid_to_string(simple_trigger_uuid))
+        from KvStore,
+          prefix: ^keyspace,
+          where: [group: "simple-triggers-by-uuid", key: ^simple_trigger_uuid]
 
-      with {:ok, _result} <- DatabaseQuery.call(client, delete_simple_trigger_query),
-           {:ok, _result} <- DatabaseQuery.call(client, delete_astarte_ref_query) do
-        :ok
-      else
-        not_ok ->
-          _ = Logger.warning("Database error: #{inspect(not_ok)}.", tag: "db_error")
-          {:error, :cannot_delete_simple_trigger}
-      end
+      _ = Repo.delete_all(delete_astarte_ref_query)
+      _ = Repo.delete_all(delete_simple_trigger_query)
+
+      :ok
     end
   end