DUP: use all connection options for AMQP #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use just the `host` option to let the consumer connect to AMQP, use the full opts set. Signed-off-by: Arnaldo Cesco <[email protected]>
Annopaolo
added
the
app:data_updater_plant
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1018 +/- ##
==========================================
+ Coverage 68.45% 69.33% +0.88%
==========================================
Files 282 275 -7
Lines 7488 7149 -339
==========================================
- Hits 5126 4957 -169
+ Misses 2362 2192 -170 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
matt-mazzucato
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use just the
hostoption to let the consumer connect to AMQP, use the full opts set.What this PR does / why we need it:
Allow to connect to any AMQP broker.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g. usage docs, diagrams, etc.: