-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: arm64 #1054
feature: arm64 #1054
Conversation
Scylladb old container version raises an error on macos: ``` 15:06:49.420 [error] GenServer :xandra terminating 2024-11-22 16:06:49 ** (CaseClauseError) no case clause matching: {:error, {{{:badmatch, {:error, {:bad_return, {DBConnection.ConnectionPool.Pool, :init, {:child_spec, 1}}}}}, [{DBConnection.ConnectionPool, :init, 1, [file: ~c"lib/db_connection/connection_pool.ex", line: 48]}, {:gen_server, :init_it, 2, [file: ~c"gen_server.erl", line: 962]}, {:gen_server, :init_it, 6, [file: ~c"gen_server.erl", line: 917]}, {:proc_lib, :init_p_do_apply, 3, [file: ~c"proc_lib.erl", line: 241]}]}, {:child, :undefined, {{172, 20, 0, 5}, 9042}, {Xandra, :start_link, [[authentication: {Xandra.Authenticator.Password, [username: "cassandra", password: "cassandra"]}, pool_size: 10, encryption: false, nodes: ["172.20.0.5:9042"], registry: :"Elixir.Xandra.ClusterRegistry.9", connection_listeners: [#PID<0.1354.0>]]]}, :transient, false, 5000, :worker ```` Signed-off-by: Gabriele Ghio <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1054 +/- ##
==========================================
- Coverage 69.23% 69.22% -0.02%
==========================================
Files 275 275
Lines 7193 7193
==========================================
- Hits 4980 4979 -1
- Misses 2213 2214 +1 ☔ View full report in Codecov by Sentry. |
- astarte platform deps are now github based - forced re2 to use >= 1.9.8
5d68b46
to
77018fb
Compare
raise Xandra.Error, reason: :agreement_timeout, message: "Schema agreement wait timeout." | ||
|
||
{:error, :no_schema_change} -> | ||
Xandra.Error.new(:no_schema_change, "Statement did not change the schema_version.") | ||
raise Xandra.Error, | ||
reason: :no_schema_change, | ||
message: "Statement did not change the schema_version." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raise
s here would break the flow in some places where the function is called inside a with
(e.g. here). Let's go back to use the {:error, %Xandra.Error{}}
return value
- Xandra.Error.new -> raise Xandra.Error
77018fb
to
17f5729
Compare
Enhance arm64 Compatibility and Development Setup
Key Changes
arm64
.astarte
deps are now github basedre2
is forced >= 1.9.8 to fix arm64 buildMinor Changes